<html>
<head><meta charset="utf-8"><title>boxed_local fallout? · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html">boxed_local fallout?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="216260047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216260047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216260047">(Nov 10 2020 at 19:15)</a>:</h4>
<p>There is a bunch of code in <code>tests/ui/escape_analysis.rs</code> that produced warns at one point but does not any more. The stderr output got lost in a <a href="https://github.com/rust-lang/rust-clippy/issues/1766">big refactor</a>. I guess there were upstream changes that broke the lint. Can anyone provide more insight on this? Does the lint need fixing?</p>



<a name="216260991"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216260991" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216260991">(Nov 10 2020 at 19:22)</a>:</h4>
<p>See the current <a href="https://github.com/rust-lang/rust-clippy/blob/master/tests/ui/escape_analysis.stderr">escape_analysis.stderr</a> file. There are 2 warning in it. But I think this testfile could use some cleanup.</p>



<a name="216261287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216261287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216261287">(Nov 10 2020 at 19:25)</a>:</h4>
<p>There were many more warns that got deleted in the refactor.</p>



<a name="216261434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216261434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216261434">(Nov 10 2020 at 19:26)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-clippy/blob/dd9051507b8eafe50cc49885cd08912b2d6ae05e/tests/ui/escape_analysis.stderr">https://github.com/rust-lang/rust-clippy/blob/dd9051507b8eafe50cc49885cd08912b2d6ae05e/tests/ui/escape_analysis.stderr</a></p>



<a name="216261574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216261574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216261574">(Nov 10 2020 at 19:27)</a>:</h4>
<p>I don't think that refactor has any relevance anymore, since it was in May 2017.  The <code>clippy_tests</code> dir doesn't even exist anymore, like many other things from back then</p>



<a name="216261903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216261903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216261903">(Nov 10 2020 at 19:29)</a>:</h4>
<p>Yes but the stderr files were moved in that refactor, except for this one. It was just deleted.</p>



<a name="216262092"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216262092" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216262092">(Nov 10 2020 at 19:31)</a>:</h4>
<p>If you look at <a href="http://escape_analysis.rs">escape_analysis.rs</a>, there is code that is clearly intended to produce warns that are not. Like the warn_call method.</p>



<a name="216262552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216262552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216262552">(Nov 10 2020 at 19:34)</a>:</h4>
<p>Since most of it are tests for the <code>box T</code> syntax, I guess we stopped linting that. No idea if intentional or what the reason behind that would be. This refactor was done 1 year before I even started working on Clippy.</p>



<a name="216262612"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216262612" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216262612">(Nov 10 2020 at 19:34)</a>:</h4>
<p>Some git magic might be able to figure out what happened to those test cases</p>



<a name="216262658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216262658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216262658">(Nov 10 2020 at 19:35)</a>:</h4>
<p><code>git log -- clippy_tests</code> should work</p>



<a name="216262683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216262683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216262683">(Nov 10 2020 at 19:35)</a>:</h4>
<p>and if you pass <code>--follow</code> it might even tell you where it was moved</p>



<a name="216262886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216262886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216262886">(Nov 10 2020 at 19:36)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> for more git magic, see <a href="https://github.com/rust-lang/rust/issues/76268#mentoring-instructions-for-reviewers">https://github.com/rust-lang/rust/issues/76268#mentoring-instructions-for-reviewers</a></p>



<a name="216263047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216263047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216263047">(Nov 10 2020 at 19:37)</a>:</h4>
<p>great for reviewing renamed files, not just seeing where they went</p>



<a name="216263256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216263256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216263256">(Nov 10 2020 at 19:39)</a>:</h4>
<p>I did lot's of git trolling before deciding that refactor is where they disappeared and never mentioned again.</p>



<a name="216263329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/boxed_local%20fallout%3F/near/216263329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/boxed_local.20fallout.3F.html#216263329">(Nov 10 2020 at 19:39)</a>:</h4>
<p>Mainly <code>git log -p -S'some code'</code></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>